Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.assimulo: init at 3.0 [WIP] [Help needed] #55408

Closed
wants to merge 1 commit into from
Closed

pythonPackages.assimulo: init at 3.0 [WIP] [Help needed] #55408

wants to merge 1 commit into from

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Feb 7, 2019 •
edited

Motivation for this change

Add Assimulo package: https://jmodelica.org/assimulo/

EDIT: Ready for review!

This is still work in progress. The build fails at the very end: EDIT: fixed this error, now tests failing

...
removing build/bdist.linux-x86_64/wheel
sortvarnames: failed to compute dependencies because of cyclic dependencies between am, n
sortvarnames: failed to compute dependencies because of cyclic dependencies between am, n
installing
/nix/store/yax21ms90cwr2l4rygd60wfbpfwg5hip-stdenv-linux/setup: line 1307: pushd: dist: No such file or directory
note: keeping build directory '/tmp/nix-build-python3.7-assimulo-3.0.drv-5'
builder for '/nix/store/3jj55c5kdgnsnd4lj4rpmfpkq19gh6cw-python3.7-assimulo-3.0.drv' failed with exit code 1
error: build of '/nix/store/3jj55c5kdgnsnd4lj4rpmfpkq19gh6cw-python3.7-assimulo-3.0.drv' failed

So apparently dist directory is missing for some reason. The build phase doesn't create it as it should, I suppose. Any help would be great!

Full log: assimulo.log

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner February 7, 2019 17:48
@jluttine
Copy link
Member Author

jluttine commented Feb 7, 2019

For some reason I don't know, dist directory seems to be under build. So I'll just move it from there. No idea why this is happening but it seems to solve this issue I'm having.

Now it fails on check phase, but I'll continue on that.

@jluttine
Copy link
Member Author

jluttine commented Feb 8, 2019

Fixed the tests by explicitly going into the correct tests directory and running nosetests there.

This is now building ok and nox review passes. Ready for review and merging. FYI, @FRidh

@costrouc
Copy link
Member

costrouc commented Feb 9, 2019

I think that you will want to build with openblas instead of liblapack and blas. The performance will be much better and this is the pattern that many other packages follow.

@jluttine
Copy link
Member Author

jluttine commented Feb 9, 2019 •
edited

Yeah, I would. However, I had a few issues with that when I tried:

  • Assimulo wants static versions of the libraries. I wasn't sure how to get a static version of openblas.
  • Assimulo expects to find liblapack.a, that's hard-coded, as far as I can see. Perhaps removing that with a patch could help.

Given both of these issues, I thought why not just use libblas.a and liblapack.a as they are available. Is there something wrong with them?

@jluttine
Copy link
Member Author

jluttine commented Feb 9, 2019

Not sure if I could patch it so that it'd use the shared libraries. Could try that if it sounds like something that could potentially work.

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

Are there any updates on this pull request, please?

@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

Nothing happening so closing.

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jluttine @costrouc @mmahut @FRidh @ryantm @GrahamcOfBorg