Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update max line length in systemd units #55496

Merged
merged 1 commit into from Feb 10, 2019
Merged

Update max line length in systemd units #55496

merged 1 commit into from Feb 10, 2019

Conversation

olorin
Copy link
Contributor

@olorin olorin commented Feb 10, 2019

The length check was introduced[0] to match systemd's max line
length. This limit has been increased[1][2] to 1MiB, starting with
systemd v235.

[0] #3403
[1] systemd/systemd@e6dde45
(relevant systemd commit)
[2] systemd/systemd#3302
(more context on systemd change)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@olorin
nixos/systemd: update max line length in systemd units
3755577 
The length check was introduced[0] to match systemd's max line
length. This limit has been increased[1][2] to 1MiB, starting with
systemd v235.

[0] NixOS#3403
[1] systemd/systemd@e6dde45
    (relevant systemd commit)
[2] systemd/systemd#3302
    (more context on systemd change)
@Mic92 Mic92 merged commit 84e4ccc into NixOS:master Feb 10, 2019
@olorin olorin deleted the topic/systemd-env-length branch February 10, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olorin @Mic92 @GrahamcOfBorg @Janik-Haag