Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixos manual: error out on missing IDs #55436

Merged
merged 2 commits into from Mar 9, 2019
Merged

Conversation

layus
Copy link
Member

@layus layus commented Feb 8, 2019

missing ids are generated randomly by docbook, and make the manual
non-reproducible.
This force-fails the build on such cases.

See #55375 and #55396

/cc @grahamc, @samueldr, @matthewbauer

  • Tested failure on missing IDs
  • Tested success when no IDs are missing
  • Fits CONTRIBUTING.md.

Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea :) thank you!

@grahamc grahamc merged commit 777e94d into NixOS:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants