Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_7.clang-unwrapped: don’t link to libatomic on darwin #55489

Merged
merged 1 commit into from Feb 10, 2019
Merged

llvmPackages_7.clang-unwrapped: don’t link to libatomic on darwin #55489

merged 1 commit into from Feb 10, 2019

Conversation

matthewbauer
Copy link
Member

Motivation for this change

Not sure why this is needed, but it fixed clang/llvm builds on macOS. Comment left about this in LLVM:

https://reviews.llvm.org/D44248#1391798

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Feb 9, 2019
@matthewbauer
Copy link
Member Author

@GrahamcOfBorg build llvmPackages_7.clang-unwrapped

@matthewbauer matthewbauer merged commit 73885bc into NixOS:master Feb 10, 2019
@matthewbauer matthewbauer deleted the fix-clang-7 branch February 22, 2019 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewbauer @GrahamcOfBorg