Fix: volume slider behavior in music gui #7209
Conversation
| @@ -26,6 +26,7 @@ | |||
| #include "string_func.h" | |||
| #include "settings_type.h" | |||
| #include "settings_gui.h" | |||
| #include "tilehighlight_func.h" | |||
There was a problem hiding this comment.
It's strange to require tilehighlight_func when not working with tiles at all, but I know it's needed for drag stuff (used in other GUI too)
There was a problem hiding this comment.
I agree -_- this is required to use SetObjectToPlaceWnd(). depot_gui.cpp uses this function in a similar way, to allow for dragging vehicles to be sold in the depot window.
Maybe the window system's dragging events were only anticipated to be used with tiles? I think it may make sense to move SetObjectToPlaceWnd() out of tilehighlight_func.h, as it's useful for dragging events inside windows that don't work with tiles at all.
|
In master, moving the mouse away from the widget stops all further response, and you need to click and drag again to change volume. As it stands, this PR makes the sliders continue to respond if you move the mouse away from the widget and then back. I think it would be better if the sliders continued to respond whilst the cursor is off the widget, until dragging is stopped. |
nikolas
force-pushed
the
volume-slider-fix
branch
from
c58f18c to
89b2dbd
Compare
|
I've updated this PR to behave in the way you described, and yeah, it is much better. |
nikolas
force-pushed
the
volume-slider-fix
branch
from
89b2dbd to
c7c9f76
Compare
In the music gui, the volume sliders don't respond to mouse drags that extend outside of their small area. This changes the event code to give them more typical dragging behavior that's easier to work with.
nikolas
force-pushed
the
volume-slider-fix
branch
from
c7c9f76 to
9a82307
Compare
|
This works but I'd like to look at how scrollbars achieve the same result. |
|
Good point.. It looks like scrollbar dragging is handled in window.cpp's It might be appropriate to add a Though, that may add some complexity, as we'll still want to do the actual volume-setting in |
|
#7227 extends scrollbar handling to allow generic widget dragging without needing to use bits of tile highlight functions. |
|
Great, that's a nicer solution, and the volume sliders are working well for me on that branch. |
In the music gui, the volume sliders don't respond to mouse drags
that extend outside of their small area.
This changes the event code to give them more typical dragging behavior
that's easier to work with.