Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cups: Fix Unable to encrypt connection: #55517

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

florianjacob
Copy link
Contributor

@florianjacob florianjacob commented Feb 10, 2019

Unable to create server credentials
by creating /var/lib/cups/ssl directory.

Motivation for this change

Partial fix for #23993, makes this troubleshooting unnecessary: https://nixos.wiki/wiki/Printing#Upgrade_Required

Reproduce wtih: lpstat -E -s, which tries to list all printers over an encrypted connection.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 10, 2019
@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg test printing

@florianjacob
Copy link
Contributor Author

Expanded the printing test to cover this.

@@ -334,6 +334,10 @@ in
[ ! -e "/var/lib/cups/$i" ] && ln -s "${rootdir}/etc/cups/$i" "/var/lib/cups/$i"
done

# While cups will automatically create self-signed certificates if accessed via TLS,
# this directory to store the certificates needs to be created manually.
mkdir -m 0700 -p /var/lib/cups/ssl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make more sense for this to be up at line 314 where the other directories are created

Copy link
Contributor Author

@florianjacob florianjacob Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I wrongly interpreted the lines above for moving /etc/cups to /var/lib/cups to interfere with /var/ib/cups/ssl, but I was wrong. Moved up.

Unable to create server credentials
by creating /var/lib/cups/ssl directory.
@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg test printing

@infinisil infinisil merged commit b1bda29 into NixOS:master Feb 14, 2019
@florianjacob florianjacob deleted the cups-fix-ssl-dir branch February 14, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants