nixos/cups: Fix Unable to encrypt connection: #55517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianjacob
force-pushed
the
cups-fix-ssl-dir
branch
from
14bdda1
to
00570ba
Compare
|
@GrahamcOfBorg test printing |
|
Expanded the printing test to cover this. |
infinisil
reviewed
Feb 14, 2019
| @@ -334,6 +334,10 @@ in | |||
| [ ! -e "/var/lib/cups/$i" ] && ln -s "${rootdir}/etc/cups/$i" "/var/lib/cups/$i" | |||
| done | |||
|
|
|||
| # While cups will automatically create self-signed certificates if accessed via TLS, | |||
| # this directory to store the certificates needs to be created manually. | |||
| mkdir -m 0700 -p /var/lib/cups/ssl | |||
There was a problem hiding this comment.
It would make more sense for this to be up at line 314 where the other directories are created
There was a problem hiding this comment.
Agreed, I wrongly interpreted the lines above for moving /etc/cups to /var/lib/cups to interfere with /var/ib/cups/ssl, but I was wrong. Moved up.
Unable to create server credentials by creating /var/lib/cups/ssl directory.
florianjacob
force-pushed
the
cups-fix-ssl-dir
branch
from
00570ba
to
33b3272
Compare
|
@GrahamcOfBorg test printing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unable to create server credentials
by creating /var/lib/cups/ssl directory.
Motivation for this change
Partial fix for #23993, makes this troubleshooting unnecessary: https://nixos.wiki/wiki/Printing#Upgrade_Required
Reproduce wtih:
lpstat -E -s, which tries to list all printers over an encrypted connection.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)