Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslinux: 2015-11-09 -> 2019-02-07 #55500

Merged
merged 2 commits into from Feb 14, 2019
Merged

Conversation

samueldr
Copy link
Member

Motivation for this change

Updates to a newer version.

Main important feature:

  • Reproducibility patches

This removes the now unneeded patches. This also switches to the upstream repository instead of a GitHub mirror. Finally, adds myself as maintainer.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
  • ✔️ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ✔️ Assured whether relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

cc @grahamc (reproducibility)

Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@grahamc grahamc merged commit ccb3fdb into NixOS:master Feb 14, 2019
@samueldr samueldr deleted the update/syslinux branch February 14, 2019 23:14
vcunat added a commit that referenced this pull request Feb 19, 2019
This reverts commit 0b49d5d #55500.
I'm sorry, I'm unable to fix the build quickly in other way than
atop the older version.  Certainly feel free to improve the approach.
@vcunat
Copy link
Member

vcunat commented Feb 19, 2019

@samueldr: I'm sorry, I just hack-fixed the build now: 5559120 bce12ef.

@samueldr
Copy link
Member Author

Don't be sorry. But uh, what issue? I verified the x86_64 linux iso to work as it did with the PR and it worked.

What test did I miss? What issue did I cause?

@vcunat
Copy link
Member

vcunat commented Feb 19, 2019

I think it did work, until another binutils update. It's a build-time breakage.

@samueldr
Copy link
Member Author

Right, this explains the debian patches which I initially included, until I tested with them all disabled and saw that none were necessary :). Whew, good to know I didn't accidentally the whole build.

@samueldr samueldr mentioned this pull request Jan 15, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants