Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prusa-slicer: renamed from slic3r-prusa3d and updated 1.41.3 -> 2.0.0 #55475

Merged
merged 1 commit into from Jun 11, 2019
Merged

prusa-slicer: renamed from slic3r-prusa3d and updated 1.41.3 -> 2.0.0 #55475

merged 1 commit into from Jun 11, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Feb 9, 2019 •
edited

Motivation for this change

It seems likely to me that there will be a new stable release of slic3r-prusa3d soon. There have been quite a few changes, esp. the rewrite of components in Perl.

To avoid duplicated work, I already create this PR with a working update for 1.42.0-alpha5, so others can build on it.

Updated to the latest stable version, 2.0.0.

The slic3r-prusa3d package was renamed by upstream to PrusaSlicer with
the 2.0.0 release to reduce confusion with the slic3r package.

cc @thorstenweber83

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread Moredread changed the title (WIP) slic3r-prusa3d: 1.41.0 -> 1.42.0-alpha5 (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-alpha5 Feb 12, 2019
This was referenced Feb 12, 2019
Closed
Merged
@Moredread Moredread changed the title (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-alpha5 (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-beta Mar 21, 2019
@Moredread
Copy link
Contributor Author

@GrahamcOfBorg build slic3r-prusa3d

@Moredread Moredread force-pushed the slic3r branch 2 times, most recently from 701dc34 to 7fc5d5d Compare March 27, 2019 20:54
@Moredread Moredread changed the title (WIP) slic3r-prusa3d: 1.41.2 -> 1.42.0-beta (WIP) prusa-slicer: renamed from slic3r-prusa3d and 1.41.0 -> 2.0.0-rc May 17, 2019
@Moredread
Copy link
Contributor Author

The package was renamed to PrusaSlicer by upstream.

I'm not sure what we should call it. PrusaSlicer is the official name but the binary is named prusa-slicer.

@thorstenweber83
Copy link
Contributor

The manual says not to use uppercase letter for the attribute name: https://nixos.org/nixpkgs/manual/#sec-package-naming

So prusa-slicer is the right way to go, I think.

@Moredread Moredread changed the title (WIP) prusa-slicer: renamed from slic3r-prusa3d and 1.41.0 -> 2.0.0-rc prusa-slicer: renamed from slic3r-prusa3d and updated 1.41.3 -> 2.0.0 May 21, 2019
@Moredread
Copy link
Contributor Author

Updated to the latest stable version, 2.0.0.

It is ready for merge now. :)

@thorstenweber83 @mweinelt

@mweinelt
Copy link
Member

Builds and runs, thanks!

@thorstenweber83
Copy link
Contributor

Yes, looks good! thank you!

@ArdaXi
Copy link
Contributor

ArdaXi commented May 25, 2019

I added these changes into my overlay and ran into a crash issue in the GUI. I'm not sure if it's because of upstream changes or issues with the package, so I'm linking it here just in case:

prusa3d/PrusaSlicer#2360

@mweinelt
Copy link
Member

mweinelt commented May 25, 2019 •
edited

I see GUI freezes when I leave the window idling for some minutes in the background with some model loaded and sliced. No particular error relates to that afaict.

stdout/stderr 
[nix-shell:~/.cache/nix-review/pr-55475]$ prusa-slicer 
04:43:13 PM: Debug: Failed to connect to session manager: SESSION_MANAGER environment variable not defined
Multisample enabled

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:13.674: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:13.674: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.269: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.269: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.282: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.450: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.450: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.469: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.469: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.470: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.470: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.470: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:14.471: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.796: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.796: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.796: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.798: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.798: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.852: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:15.853: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-WARNING **: 16:43:20.369: Could not find the icon 'application-xml'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
	http://icon-theme.freedesktop.org/releases

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.770: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.770: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.781: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.782: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:43:26.782: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.557: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.558: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.558: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:44:02.559: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.376: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.377: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.379: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.379: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.379: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.878: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:18.878: IA__gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.636: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.636: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.647: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.647: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

(prusa-slicer:10968): Gtk-CRITICAL **: 16:45:21.648: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

@Moredread
prusa-slicer: renamed from slic3r-prusa3d and updated 1.41.3 -> 2.0.0
0ee35c5 
The slic3r-prusa3d package was renamed by upstream to PrusaSlicer with
the 2.0.0 release to reduce confusion with the slic3r package.

We compile against wxGTK 3.0, as with 3.1 the application crashes (see
@Moredread
Copy link
Contributor Author

Moredread commented May 26, 2019 •
edited

I've changed the PR to compile against wxGTK 3.0, as I only see the bug in prusa3d/PrusaSlicer#2360 with 3.1.

@mweinelt @ArdaXi does that work for you?

@mweinelt
Copy link
Member

Yes, that fixes "Add instance" for me.

@ArdaXi
Copy link
Contributor

ArdaXi commented May 27, 2019

Confirmed, the new version does not display this behaviour. Thanks!

@baracoder
Copy link
Contributor

Tested yesterday with nix-env -iA prusa-slicer -f https://github.com/Moredread/nixpkgs/archive/slic3r.tar.gz
Everything expect add instance worked.
To get custom profiles from the older version, you need to use Export config bundle from slic3r-pe and imported it to prusa-slicer

@ArdaXi
Copy link
Contributor

ArdaXi commented May 27, 2019

On a hunch I updated wxWidgets to 3.1.2 and the issue disappeared as well. It might be worth upgrading wxWidgets, considering 3.1.2 came out in December, then this package can be built against 3.1 as well.

@Moredread
Copy link
Contributor Author

Moredread commented May 28, 2019 •
edited

On a hunch I updated wxWidgets to 3.1.2 and the issue disappeared as well. It might be worth upgrading wxWidgets, considering 3.1.2 came out in December, then this package can be built against 3.1 as well.

Do you want to create the PR for wxWidgets 3.1.2? I think it would be better to review it on it's own terms, as I guess there a few packages that depend on it that need to be checked.

Should we wait before we merge this PR, or can we merge the version with wxGTK 3.0?

@ArdaXi ArdaXi mentioned this pull request May 28, 2019
Closed
10 tasks
@ArdaXi
Copy link
Contributor

ArdaXi commented May 28, 2019

I feel like the wxGTK update is a pretty significant PR which might take a while to merge. I don't personally think that there's a huge loss in having this PR build against 3.0, so I would vote to go ahead and update later.

@thorstenweber83
Copy link
Contributor

I also think we shouldn't wait for wxGTK to be updated. Let's just move to 3.1.2 later when the pull request is through.

@Moredread
Copy link
Contributor Author

In that case I think we are basically ready for merging. :)

Can somebody with commit access please remove the WIP tag?

@Moredread
Copy link
Contributor Author

@GrahamcOfBorg build prusa-slicer

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/14

@teto
Copy link
Member

teto commented Jun 11, 2019

trusting previous reviews

@teto teto merged commit dd14c5b into NixOS:master Jun 11, 2019
@Moredread Moredread deleted the slic3r branch July 7, 2019 14:10
Moredread added a commit to Moredread/nixpkgs that referenced this pull request Nov 15, 2019
@Moredread
prusa-slicer: use wxGTK31 instead of wxGTK30
9702690 
With wxGTK31 3.1.0 there was a bug causing crashes. With the recently
merged version 3.1.2 this bug has been fixed.

See NixOS#55475 for details.
@Moredread Moredread mentioned this pull request Nov 15, 2019
Merged
10 tasks
Lassulus pushed a commit that referenced this pull request Dec 3, 2019
@Moredread @Lassulus
prusa-slicer: use wxGTK31 instead of wxGTK30
ba917b2 
With wxGTK31 3.1.0 there was a bug causing crashes. With the recently
merged version 3.1.2 this bug has been fixed.

See #55475 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: clean-up 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@Moredread @thorstenweber83 @mweinelt @ArdaXi @baracoder @nixos-discourse @teto @pSub @infinisil @GrahamcOfBorg