Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rclone: 1.45 -> 1.46 #55476

Merged
merged 1 commit into from Feb 23, 2019
Merged

rclone: 1.45 -> 1.46 #55476

merged 1 commit into from Feb 23, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Feb 9, 2019

changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @danielfullmer

@dotlambda
Copy link
Member

I'm getting errors along the lines of

2019/02/09 15:50:20 ERROR : /: Dir.Stat error: couldn't list files: strconv.ParseInt: parsing "true": invalid syntax

when accessing a rclone mounted WebDAV remote.

@danielfullmer
Copy link
Contributor

@dotlambda That error looks to be addressed here: rclone/rclone#2964 Presumably we can just use the included patch if he doesn't release a new version soon.

Other than that this PR looks fine to me. I've tested briefly with my google drive encrypted mount.

@dywedir
Copy link
Member Author

dywedir commented Feb 16, 2019

@dotlambda could you please re-check?

dotlambda
dotlambda approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!

@dotlambda dotlambda merged commit b320b34 into NixOS:master Feb 23, 2019
@dywedir dywedir deleted the rclone branch February 23, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @dotlambda @danielfullmer @GrahamcOfBorg