Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 72.0.3626.81 -> 72.0.3626.96 #55501

Merged
merged 1 commit into from Feb 13, 2019
Merged

chromium: 72.0.3626.81 -> 72.0.3626.96 #55501

merged 1 commit into from Feb 13, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Feb 10, 2019 •
edited

Motivation for this change

Fixes CVE-2019-5784 according to https://chromereleases.googleblog.com/2019/02/stable-channel-update-for-desktop.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

chromium appears to be working fine including audio; haven't tested chromiumBeta or chromiumDev.

@ivan
Copy link
Member Author

ivan commented Feb 11, 2019

cc maintainers @chaoflow @bendlas

@flokli
Copy link
Contributor

flokli commented Feb 13, 2019

built chromium, chromiumBeta and chromiumDev, and ran the chromium vm test. Thanks for the PR!

@flokli flokli merged commit 516a957 into NixOS:master Feb 13, 2019
@flokli
Copy link
Contributor

flokli commented Feb 13, 2019

backported to 18.09 in e23980e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivan @flokli @samueldr @GrahamcOfBorg