Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-snap] scroll-snap-type computed value #15311

Merged

Conversation

ewilligers
Copy link
Contributor

Spec: https://drafts.csswg.org/css-scroll-snap-1/

Blink/Safari fail by reporting the scroll-snap-type computed value
as "x proximity" instead of "x".

Spec: https://drafts.csswg.org/css-scroll-snap-1/

Blink/Safari fail by reporting the scroll-snap-type computed value
as "x proximity" instead of "x".
@ewilligers
Copy link
Contributor Author

Note the following two principles in CSSOM:

If component values can be omitted or replaced with a shorter representation without changing the meaning of the value, omit/replace them.

If either of the above syntactic translations would be less backwards-compatible, do not perform them.

Blink and Safari are the only browsers that support scroll-snap-type values like "x" and "x proximity", and they give "x proximity" as the computed value, so expecting "x proximity" would be more backwards-compatible.

@ewilligers
Copy link
Contributor Author

@tabatkins please review

@tabatkins
Copy link
Contributor

Blink and Safari are the only browsers that support scroll-snap-type values like "x" and "x proximity", and they give "x proximity" as the computed value, so expecting "x proximity" would be more backwards-compatible.

Back-compat is about pages depending on the behavior, not browsers happening to have done it a particular way in the past. (That's colloquially called "bugwards compat". ^_^) This is new enough that I doubt anyone's depending on our too-long serializations, so we should continue to follow shortest-serialization principle until shown evidence otherwise.

Co-Authored-By: ewilligers <ewilligers@users.noreply.github.com>
@tabatkins tabatkins merged commit 0f9440b into web-platform-tests:master May 7, 2019
@ewilligers ewilligers deleted the scroll-margin-computed branch May 8, 2019 00:08
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
* [css-scroll-snap] scroll-snap-type computed value

Spec: https://drafts.csswg.org/css-scroll-snap-1/

Blink/Safari fail by reporting the scroll-snap-type computed value
as "x proximity" instead of "x".

* Update css/css-scroll-snap/parsing/scroll-snap-align-computed.html

Co-Authored-By: ewilligers <ewilligers@users.noreply.github.com>


Co-authored-by: Eric Willigers <ericwilligers@chromium.org>
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants