Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binutils: 2.31.1 -> 2.32 #55485

Closed
wants to merge 1 commit into from
Closed

binutils: 2.31.1 -> 2.32 #55485

wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

Fixes #51293.

@matthewbauer matthewbauer changed the base branch from master to staging February 9, 2019 17:08
@matthewbauer matthewbauer changed the base branch from staging to master February 9, 2019 17:14
@matthewbauer matthewbauer changed the base branch from master to staging February 9, 2019 17:14
@matthewbauer
Copy link
Member Author

I am getting some unexplained errors when using this. Probably better to figure those out before merging.

@dtzWill
Copy link
Member

dtzWill commented Feb 12, 2019

cc #55165 FWIW, likely same but haven't checked :).

@dtzWill dtzWill changed the title binutils: 2.30 -> 2.32 binutils: 2.31.1 -> 2.32 Feb 12, 2019
dtzWill
dtzWill reviewed Feb 12, 2019
View reviewed changes
pkgs/development/tools/misc/binutils/default.nix
# Remove gold-symbol-visibility patch when updating, the proper fix
# is now upstream.
# https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=330b90b5ffbbc20c5de6ae6c7f60c40fab2e7a4f;hp=99181ccac0fc7d82e7dabb05dc7466e91f1645d3
version = "2.31.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may wish to revise commit message since this starts with 2.31.1 not 2.30.

@dtzWill dtzWill mentioned this pull request Feb 12, 2019
Closed
10 tasks
@dtzWill
Copy link
Member

dtzWill commented Feb 12, 2019 via email

@matthewbauer
Copy link
Member Author

matthewbauer commented Feb 16, 2019 via email

@matthewbauer
Copy link
Member Author

@dtzWill here is the error I get building coreutils on x86_64-linux with this change:

mkdir: cannot change permissions of 'parent/sub': Function not implemented
parent/sub: expected d-wx--x-w-, got d-wx----w-
mkdir: cannot change permissions of 'parent/sub': Function not implemented
parent/sub: expected d-wx--x-w-, got d-wx----w-
FAIL tests/mkdir/perm.sh (exit status: 1)

It could be the machine though. I'd be interested in seeing if anyone else has the same issue.

@vcunat
Copy link
Member

vcunat commented Feb 22, 2019

Have you considered using later 2.31 branch? (no tarballs unfortunately) It happened multiple times for us that fresh binutils caused lots of failures.

@dtzWill
Copy link
Member

dtzWill commented Feb 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill left review comments

@shlevy shlevy Awaiting requested review from shlevy

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @dtzWill @vcunat @GrahamcOfBorg