Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove django 2.0 #55484

Merged
merged 1 commit into from Feb 10, 2019
Merged

Remove django 2.0 #55484

merged 1 commit into from Feb 10, 2019

Conversation

refnil
Copy link
Contributor

@refnil refnil commented Feb 9, 2019

Motivation for this change

Closing issue #54943. It wants to remove django 2.0 from nixos 19.03 because it will reach EOL soon. I did not find any package that depends on django 2.0 in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@refnil
Django: 2.0 -> removed
8cf4803 
Django 2.0 will reach EOL soon after the release of Nixos 19.03
Close issue NixOS#54943
@refnil refnil requested a review from FRidh as a code owner February 9, 2019 16:58
@Mic92 Mic92 merged commit 06b1f8f into NixOS:master Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@refnil @Mic92 @GrahamcOfBorg