Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shmig: 2017-07-24 -> 1.0.0 #53650

Merged
merged 1 commit into from Jan 30, 2019
Merged

shmig: 2017-07-24 -> 1.0.0 #53650

merged 1 commit into from Jan 30, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 8, 2019 •
edited

Motivation for this change

Update to the latest revision, don't replace which anymore as all
which references are eliminated previously, enable support for at
least one database type (otherwise this scrpit is unusable and needs to
be built manually with support for on of these packages).

Tested functionality with a simple SQLite database.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
shmig: 2017-07-24 -> 1.0.0
f494cff 
Update to the latest revision, don't replace `which` anymore as all
`which` references are eliminated previously, enable support for at
least one database type (otherwise this scrpit is unusable and needs to
be built manually with support for on of these packages).

Tested functionality with a simple SQLite database.
@Ma27 Ma27 changed the title shmig: 2017-07-24 -> 2018-11-14 shmig: 2017-07-24 -> 1.0.0 Jan 12, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jan 12, 2019

Now bumped to 1.0.0, upstream tagged the latest revision.

@Ma27 Ma27 mentioned this pull request Jan 12, 2019
Merged
@Ma27
Copy link
Member Author

Ma27 commented Jan 30, 2019

As this is not a critical package which is in the queue for a certain amount of time now, I'll merge this for now...

@Ma27 Ma27 merged commit c7001df into NixOS:master Jan 30, 2019
@Ma27 Ma27 deleted the update-shmig branch January 30, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @GrahamcOfBorg