Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] nixos/systemd-udev-settle: don't restart on upgrades #53648

Merged
merged 1 commit into from Jan 13, 2019
Merged

[backport] nixos/systemd-udev-settle: don't restart on upgrades #53648

merged 1 commit into from Jan 13, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 8, 2019 •
edited

Original from #53446

I tested this on master, but I want to wait with the backport of this commit
until it hits the unstable channel, just to be sure.

The idea is that we only need this target during boot,
however there is no point on restarting it on every upgrade.

This hopefully fixes #21954

(cherry picked from commit 0a2c8cc)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos/systemd-udev-settle: don't restart on upgrades
34a1278 
The idea is that we only need this target during boot,
however there is no point on restarting it on every upgrade.

This hopefully fixes NixOS#21954

(cherry picked from commit 0a2c8cc)
@Mic92 Mic92 merged commit 015541e into NixOS:release-18.09 Jan 13, 2019
@Mic92 Mic92 deleted the udev-settle branch January 15, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @samueldr @GrahamcOfBorg