Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsvg: init at 0.1.4 #53581

Closed
wants to merge 2 commits into from
Closed

libsvg: init at 0.1.4 #53581

wants to merge 2 commits into from

Conversation

kisonecat
Copy link
Contributor

Motivation for this change

Support for libsvg with patch to handle nixpkgs' newer libpng

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 8, 2019

What is the purpose of this library? It looks like it is ancient, not maintained, and replaced by librsvg.

@kisonecat
Copy link
Contributor Author

It's a dependency for other things (libcutter) and it appears in Arch's AUR. It is indeed very old.

I'm super new to Nix so if in your estimation this doesn't belong in nixpkgs I'm happy to close.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 8, 2019

We do not have any formal policy against adding old software but since this has been abandoned so long ago, it is quite probable there are many security issues not fixed.

Parity with AUR is not really our goal but if you find any of the packages depending on libsvg useful and want to use Nixpkgs to install it, that should be sufficient reason to include it into the package set.

More in-depth analysis would also weigh the expected future maintenance costs (more removed functions needing patching) and clutter against the usefulness of the package to other users and other subjective factors. NUR or personal overlays might be a good alternative to main nixpkgs repository in some cases.

@kisonecat
Copy link
Contributor Author

I'll close. I wasn't familiar with NUR, but that certainly seems more appropriate.

Really loving NixOS! Thanks!

@kisonecat kisonecat closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants