Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Russian dictionary for hunspell #53564

Closed
wants to merge 4 commits into from
Closed

Adding Russian dictionary for hunspell #53564

wants to merge 4 commits into from

Conversation

kaven96
Copy link
Contributor

@kaven96 kaven96 commented Jan 7, 2019 •
edited

Motivation for this change

There was no Russian dictionary for hunspell. This commit adds it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Jan 7, 2019

You are doing a PR from master of your own repository (a risky idea), and apparently you have force-pushed ksh addition over the dictionary addition

@kaven96
Copy link
Contributor Author

kaven96 commented Jan 7, 2019

@7c6f434c can you remove it and I will make new PR?

7c6f434c
7c6f434c reviewed Jan 7, 2019
View reviewed changes
pkgs/development/libraries/hunspell/dictionaries.nix
folderName = "ru_RU_UTF-8_${version}";

src = fetchurl {
url = "https://bitbucket.org/Shaman_Alex/russian-dictionary-hunspell/downloads/ru_RU_UTF-8_${version}.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you hardcode a single-language source url, it is fine but then there is no point in defining a function.

@7c6f434c
Copy link
Member

7c6f434c commented Jan 7, 2019

Well, you can also close your own PR, or we can proceed here if in the next few days you don't plan to push any changes unrelated to the current PR into your fork's master branch

@kaven96
Copy link
Contributor Author

kaven96 commented Jan 7, 2019

I think, it's better to close it, because I want to clone NixOS/nixpkgs again and add my changes through branches.

@kaven96 kaven96 closed this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaven96 @7c6f434c