Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wavesurfer #53584

Closed
wants to merge 1 commit into from
Closed

Conversation

MarcWeber
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix meta:

  • snack.meta.broken = true needs to be removed
  • wavesurfer.meta.license needs to be set as a value from stdenv.lib.licenses.*
  • snack.meta.platforms and wavesurfer.meta.platforms need to be set

See https://nixos.org/nixpkgs/manual/#chap-meta for more information


src = fetchurl {
url = https://www.speech.kth.se/wavesurfer/wavesurfer-1.8.5.tar.gz;
sha256 = "1yx9s1j47cq0v40cwq2gn7bdizpw46l95ba4zl9z4gg31mfvm807";
url = mirror://sourceforce/wavesurfer/wavesurfer/1.8.8p5/wavesurfer-1.8.8p5-src.tgz;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sourceforge?

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review veprbl's comments and change the commit message to match https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

@aanderse
Copy link
Member

@MarcWeber are you able to address the above comments?

@veprbl
Copy link
Member

veprbl commented Dec 27, 2019

Since there is no activity, let's close.

@veprbl veprbl closed this Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants