Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual: limit text width #53634

Merged
merged 1 commit into from Jan 18, 2019
Merged

manual: limit text width #53634

merged 1 commit into from Jan 18, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 8, 2019

Currently the manual scales to the view port of the browser.
This leads to an unreadable layout and I found myself
reading the xml source instead.
The optimal width would be around 50 characters per line.
Since we have code listings also in the manual I relaxed
this limit a bit towards 70 characters per line.

cc @grahamc

@7c6f434c
Copy link
Member

7c6f434c commented Jan 8, 2019

Should it be width or max-width? Should it be px or em?

(of course it is sad when we hardcode the layout preferred by some instead of people using the numerous options present in browsers to control the layout, but I think we should at least minimize the harm to people who actually do configure the browser)

@Mic92
Copy link
Member Author

Mic92 commented Jan 8, 2019

Yeah. it should be probably max-width and em. I already forgot again how to write proper responsive css.

@grahamc
Copy link
Member

grahamc commented Jan 8, 2019

Looks like it needs to be max-width still, but otherwise lgtm.

Currently the manual scales to the view port of the browser.
This leads to an unreadable layout and I found myself
reading the xml source instead.
The optimal width would be around 50 characters per line.
Since we have code listings also in the manual I relaxed
this limit a bit towards 70 characters per line.
@Mic92
Copy link
Member Author

Mic92 commented Jan 8, 2019

Fixed

@Mic92 Mic92 merged commit 14474a4 into NixOS:master Jan 18, 2019
@Mic92 Mic92 deleted the text-width branch January 18, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants