Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine{Unstable,Staging}: 4.0-rc2 -> 4.0-rc5 #53602

Merged
merged 1 commit into from Jan 11, 2019
Merged

wine{Unstable,Staging}: 4.0-rc2 -> 4.0-rc5 #53602

merged 1 commit into from Jan 11, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jan 7, 2019

Motivation for this change

Version bump

https://www.winehq.org/announce/4.0-rc3
https://www.winehq.org/announce/4.0-rc4
https://www.winehq.org/announce/4.0-rc5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I confirmed that foobar2000 1.4.1 works with wineUnstable 4.0-rc5, and that winecfg works.

rnhmjoj
rnhmjoj approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a few D3D9 and openGL games, DXVK for both staging and unstable 32bit and WoW.

@worldofpeace worldofpeace merged commit 9ccd647 into NixOS:master Jan 11, 2019
@veprbl
Copy link
Member

veprbl commented Jan 23, 2019

4.0 is out https://www.winehq.org/announce/4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ivan @veprbl @rnhmjoj @GrahamcOfBorg @worldofpeace