Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc: 3.0.3 -> 3.1.0 #53611

Merged
merged 2 commits into from Feb 8, 2019
Merged

lxc: 3.0.3 -> 3.1.0 #53611

merged 2 commits into from Feb 8, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jan 8, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/lxc/versions.

meta.description for lxc is: '"Userspace tools for Linux Containers, a lightweight virtualization system"'.

Checks done (click to expand)
  • built on NixOS
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-attach passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-autostart passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-cgroup passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-checkpoint passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-copy passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-config passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-console passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-create passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-destroy passed the binary check.
  • Warning: no invocation of /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-device had a zero exit code or showed the expected version
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-execute passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-freeze passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-info passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-ls passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-monitor passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-snapshot passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-start passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-stop passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-top passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-unfreeze passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-unshare passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-wait passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-usernsexec passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-checkconfig passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-update-config passed the binary check.
  • /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/init.lxc passed the binary check.
  • 25 of 26 passed binary check by having a zero exit code.
  • 21 of 26 passed binary check by having the new version present in output.
  • found 3.1.0 with grep in /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0
  • directory tree listing: https://gist.github.com/e533063d27ffecf6228556098f20e401
  • du listing: https://gist.github.com/4405f6dd8ba28bff76357a20613eb162
Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
haskellPackages.bindings-lxc
lxc
lxd
pipework
python27Packages.lxc

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A lxc https://github.com/r-ryantm/nixpkgs/archive/1db3185eea44da57fd2008687ca38946f59e6b4e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0
ls -la /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin

cc @wkennington @globin @fpletz for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/lxc/versions
@cw789
Copy link
Contributor

cw789 commented Feb 6, 2019

I'm interested in when this PR will get merged?

@ryantm
Copy link
Member

ryantm commented Feb 7, 2019

@cw789 have you tested it is good?

@cw789
Copy link
Contributor

cw789 commented Feb 7, 2019

@cw789 have you tested it is good?

I'll check it today.

@cw789
Copy link
Contributor

cw789 commented Feb 7, 2019

Ok, so I'm still not very deep into Nix - but hope to get better.
I only get it running if I remove the docbook things.

{ stdenv, fetchurl, autoreconfHook, pkgconfig, perl, python3Packages, pam

# Optional Dependencies
, libcap ? null, libapparmor ? null, libselinux ? null, libseccomp ? null, gnutls ? null
, systemd ? null
}:

with stdenv.lib;
stdenv.mkDerivation rec {
  name = "lxc-${version}";
  version = "3.1.0";

  src = fetchurl {
    url = "https://linuxcontainers.org/downloads/lxc/lxc-${version}.tar.gz";
    sha256 = "4d8772c25baeaea2c37a954902b88c05d1454c91c887cb6a0997258cfac3fdc5";
  };

  nativeBuildInputs = [
    autoreconfHook pkgconfig perl python3Packages.wrapPython
  ];
  buildInputs = [
    pam
    libcap libapparmor libselinux libseccomp gnutls
    systemd
  ];

  postPatch = ''
    sed -i '/chmod u+s/d' src/lxc/Makefile.am
  '';

  configureFlags = [
    "--enable-pam"
    "--localstatedir=/var"
    "--sysconfdir=/etc"
    "--disable-api-docs"
    "--with-init-script=none"
    "--with-distro=nixos" # just to be sure it is "unknown"
  ] ++ optional (libapparmor != null) "--enable-apparmor"
    ++ optional (libselinux != null) "--enable-selinux"
    ++ optional (libseccomp != null) "--enable-seccomp"
    ++ optional (libcap != null) "--enable-capabilities"
    ++ [
    "--disable-examples"
    "--enable-python"
    "--disable-lua"
    "--enable-bash"
    (if doCheck then "--enable-tests" else "--disable-tests")
    "--with-rootfs-path=/var/lib/lxc/rootfs"
  ];

  doCheck = false;

  installFlags = [
    "localstatedir=\${TMPDIR}"
    "sysconfdir=\${out}/etc"
    "sysconfigdir=\${out}/etc/default"
    "bashcompdir=\${out}/share/bash-completion/completions"
    "READMEdir=\${TMPDIR}/var/lib/lxc/rootfs"
    "LXCPATH=\${TMPDIR}/var/lib/lxc"
  ];

  postInstall = ''
    wrapPythonPrograms
  '';

  meta = {
    homepage = https://linuxcontainers.org/;
    description = "Userspace tools for Linux Containers, a lightweight virtualization system";
    license = licenses.lgpl21Plus;

    longDescription = ''
      LXC is the userspace control package for Linux Containers, a
      lightweight virtual system mechanism sometimes described as
      "chroot on steroids". LXC builds up from chroot to implement
      complete virtual systems, adding resource management and isolation
      mechanisms to Linux’s existing process management infrastructure.
    '';

    platforms = platforms.linux;
    maintainers = with maintainers; [ wkennington globin fpletz ];
  };
}

@ryantm
Copy link
Member

ryantm commented Feb 8, 2019

@cw789 You had trouble building it? r-ryantm and ofborg didn't have an issue, so sounds like it is probably okay then?

You could try testing it via the instructions in the pull request message at the top.

@Mic92 Mic92 merged commit b2d9782 into NixOS:master Feb 8, 2019
@Mic92
Copy link
Member

Mic92 commented Feb 8, 2019

I tested both lxc and lxd and they seem to work fine.

@cw789
Copy link
Contributor

cw789 commented Feb 8, 2019

You could try testing it via the instructions in the pull request message at the top.

Thanks, everything working.

@jokogr
Copy link
Contributor

jokogr commented Feb 8, 2019

@Mic92 that was fast for LXD, is it OK that I create also lxd-lts? LXD 3.x are feature releases, while LXD 3.0.x is the current LTS one. I will also have to check that lxc is working with lxd-lts

@Mic92
Copy link
Member

Mic92 commented Feb 9, 2019

@jokogr how long do lts versions last?

@r-ryantm r-ryantm deleted the auto-update/lxc branch February 15, 2019 02:57
@jokogr
Copy link
Contributor

jokogr commented Mar 3, 2019

@Mic92 sorry for not catching this earlier, according to this: "LXD 3.0.3 is supported until June 2023 and is our current LTS release, users are encouraged to update to the latest bugfix releases as they're made available."

I will try to package an LTS package later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants