Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keybase and related packages #53590

Merged
merged 3 commits into from Jan 8, 2019
Merged

Update keybase and related packages #53590

merged 3 commits into from Jan 8, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

#50999 (comment)
cc @voobscout for testing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace self-assigned this Jan 7, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build keybase kbfs keybase-gui

@voobscout
Copy link
Contributor

Tested, it works properly again. Thanks @rvolosatovs

@worldofpeace worldofpeace merged commit 3bc3772 into NixOS:master Jan 8, 2019
@worldofpeace
Copy link
Contributor

Updates to this were backported last round #51264, but that was for security reasons.

I'm not sure if we need it, though it wouldn't hurt.

@rvolosatovs rvolosatovs deleted the update/keybase branch January 8, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@worldofpeace worldofpeace

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @worldofpeace @voobscout @GrahamcOfBorg