Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] github-desktop: add GitHub Desktop to NixOS #53637

Closed
wants to merge 1 commit into from
Closed

[WIP] github-desktop: add GitHub Desktop to NixOS #53637

wants to merge 1 commit into from

Conversation

ghuntley
Copy link
Member

@ghuntley ghuntley commented Jan 8, 2019 •
edited

Motivation for this change

Howdy folks,

This is a work in progress and I'm opening it early for feedback. It is not ready for merging. Whilst the expression builds successfully the application does not load yet. If anyone has some spare cycles to help out that would be k-rad. The upstream repository we are building from is https://github.com/shiftkey/desktop

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghuntley ghuntley mentioned this pull request Jan 8, 2019
Open
flokli
flokli requested changes Jan 8, 2019
View reviewed changes
pkgs/applications/version-management/github-desktop/default.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/github-desktop/default.nix Outdated

chmod -R g-w $out

# patch the binaries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try if adding autopatchelfHook to nativeBuildInputs works, so you don't need to manually patchelf and assemble rpath…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, thankyou for the recommendation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to autopatchelfHookmade a substantial difference to the cleanliness/maintainability of the expression. It's currently failing atm in the patching phase. Have pushed code for the night and intend to pick this up again soon.

@aanderse
Copy link
Member

aanderse commented Aug 4, 2019

@ghuntley any motivation to continue with this PR?

flokli
flokli requested changes Aug 18, 2019
View reviewed changes
pkgs/applications/version-management/github-desktop/default.nix
let
version = "1.6.0";

deps = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be unused now.

pkgs/applications/version-management/github-desktop/default.nix
in

stdenv.mkDerivation {
name = "github-desktop-${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "github-desktop-${version}";
pname = "github-desktop";

pkgs/applications/version-management/github-desktop/default.nix
};

dontBuild = true;
buildInputs = [ dpkg ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that also belongs into nativeBuildInputs.

pkgs/applications/version-management/github-desktop/default.nix
cp -r ./opt/GitHub\ Desktop $out
'';

runtimeDependencies = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused?

pkgs/applications/version-management/github-desktop/default.nix
gnome3.gtk
];

meta = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = {
meta = with stdenv.lib; {

pkgs/applications/version-management/github-desktop/default.nix
meta = {
description = "Desktop client for GitHub";
homepage = "https://github.com/desktop/desktop/issues/1525";
license = stdenv.lib.licenses.unfree;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = stdenv.lib.licenses.unfree;
license = licenses.unfree;

pkgs/applications/version-management/github-desktop/default.nix
homepage = "https://github.com/desktop/desktop/issues/1525";
license = stdenv.lib.licenses.unfree;
platforms = [ "x86_64-linux" ];
maintainers = [ stdenv.lib.maintainers.ghuntley ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = [ stdenv.lib.maintainers.ghuntley ];
maintainers = with maintainers; [ ghuntley ];

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:10
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
@rileyinman
Copy link
Contributor

Closing as this has since been added to nixpkgs.

@rileyinman rileyinman closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ghuntley @aanderse @rileyinman @flokli @ryantm @GrahamcOfBorg