Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

culmus: add .otf, .pfa and .afm files #53638

Merged
merged 4 commits into from Jan 11, 2019
Merged

culmus: add .otf, .pfa and .afm files #53638

merged 4 commits into from Jan 11, 2019

Conversation

yochai
Copy link
Contributor

@yochai yochai commented Jan 8, 2019

Motivation for this change

DavidCLM changed from ttf to otf with the change from 0.130 to 0.133, otf files was not handled.

Things done

Used the font successfully on NixOS

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

@GrahamcOfBorg build culmus

@markuskowa markuskowa self-assigned this Jan 10, 2019
markuskowa
markuskowa requested changes Jan 10, 2019
View reviewed changes
pkgs/data/fonts/culmus/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/culmus/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/culmus/default.nix Outdated Show resolved Hide resolved
@markuskowa
Copy link
Member

@GrahamcOfBorg build culmus

@markuskowa markuskowa merged commit 10b50b6 into NixOS:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees

@markuskowa markuskowa

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yochai @markuskowa @GrahamcOfBorg