Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.entrypoints: 0.2.3 -> 0.3 #53593

Closed
wants to merge 1 commit into from
Closed

python.pkgs.entrypoints: 0.2.3 -> 0.3 #53593

wants to merge 1 commit into from

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 7, 2019

Motivation for this change

The upstream issue requiring one test to be disabled was fixed:
takluyver/entrypoints#23

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
python.pkgs.entrypoints: 0.2.3 -> 0.3
2cb5675 
The upstream issue requiring one test to be disabled was fixed:
takluyver/entrypoints#23
@timokau timokau requested a review from FRidh as a code owner January 7, 2019 19:13
@timokau
Copy link
Member Author

timokau commented Jan 7, 2019

@GrahamcOfBorg build python2.pkgs.entrypoints python3.pkgs.entrypoints

@timokau
Copy link
Member Author

timokau commented Jan 7, 2019

nix-review shows that this breaks nbconvert and therefore jupyter. So it should not be merged in isolation. @FRidh can I re-target the PR somewhere or is your python branch still regarded private?

@FRidh
Copy link
Member

FRidh commented Jan 8, 2019

No, we can keep it open as WIP. It's not likely to be merged anytime soon.

We're going to have a huge challenge resolving dependencies considering the package set has grown significantly, and because plenty of packages are dropping Python 2 support, requiring different versions for 2 and 3.

@timokau
Copy link
Member Author

timokau commented Jan 8, 2019

Alright. At least at the end of all these issues we'll be able to drop python2 ourselves.

@dotlambda
Copy link
Member

included in #55757

@dotlambda dotlambda closed this Feb 14, 2019
@timokau timokau deleted the entrypoints-0.3 branch February 14, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @FRidh @dotlambda @GrahamcOfBorg