Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubioath-desktop: Fix the desktop icon #53560

Closed
wants to merge 1 commit into from
Closed

yubioath-desktop: Fix the desktop icon #53560

wants to merge 1 commit into from

Conversation

ejpcmac
Copy link
Contributor

@ejpcmac ejpcmac commented Jan 7, 2019

Motivation for this change

yubioath-desktop did not have an icon in the applications menu.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
Copy link
Contributor

danbst commented Jan 23, 2019

This was much rewritten in #54215
Reopen if you still have this issue on latest master

@danbst danbst closed this Jan 23, 2019
@ejpcmac ejpcmac deleted the fix-yubioath-desktop-icon branch January 23, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ejpcmac @danbst @GrahamcOfBorg