aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 #53565

NRHelmi · 2019-01-07T14:27:07Z

Motivation for this change

The AWS X-Ray daemon is a software application that listens for traffic on UDP port 2000, gathers raw segment data, and relays it to the AWS X-Ray API.

The pull request contains the xray daemon packaged next to its nixos service.
This should add support to aws xray daemon in nixos.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions (ubuntu 16.04)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)

nix path-info -rS /nix/store/gbppfb3i7xv6lp7n5ng015x09kqmldnj-aws-xray-daemon-V3.0.0-bin
/nix/store/794g4fijpi67xk9ri99f8i0hhmj49rr9-tzdata-2018g              	    2095096
/nix/store/gbppfb3i7xv6lp7n5ng015x09kqmldnj-aws-xray-daemon-V3.0.0-bin	   37261432
/nix/store/xdsjx0gba4id3yyqxv66bxnm2sqixkjj-glibc-2.27                	   25010568
/nix/store/yzfwmssgpkff21f4xcnk2m8vav6nwlah-iana-etc-20180905         	     562856

Assured whether relevant documentation is up to date
Fits CONTRIBUTING.md.

I think I'm missing the maintainer. Don't know who to set to ?

AmineChikhaoui · 2019-01-07T14:59:24Z

@GrahamcOfBorg build aws-xray-daemon

AmineChikhaoui · 2019-01-07T15:00:09Z

@NRHelmi indentation is 2 spaces in nix

nixos/modules/services/monitoring/aws-xray-daemon.nix

AmineChikhaoui · 2019-01-10T14:49:00Z

@GrahamcOfBorg build aws-xray-daemon

nixos-discourse · 2019-01-31T13:51:01Z

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-january/2002/3

nixos/modules/services/monitoring/aws-xray-daemon.nix

This reverts commit d74ea5e.

nixos-discourse · 2019-04-11T12:05:29Z

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/18

ryantm · 2019-04-11T15:14:26Z

nixos/modules/services/monitoring/aws-xray-daemon.nix

+in
+{
+  options.services.aws-xray-daemon = {
+    enable = mkEnableOption "Whether to enable aws-xray-daemon service";


Suggested change

enable = mkEnableOption "Whether to enable aws-xray-daemon service";

enable = mkEnableOption "the aws-xray-daemon service";

The "whether to enable" part gets added automatically.

ryantm · 2019-04-11T15:15:42Z

pkgs/tools/networking/aws-xray-daemon/default.nix

+
+buildGoPackage rec {
+  name = "aws-xray-daemon-${version}";
+  version = "V3.0.0";


It's not typical to have the prefix of V in the version, even if it is in the tag or release name.

Suggested change

version = "V3.0.0";

version = "3.0.0";

ryantm · 2019-04-11T15:16:33Z

pkgs/tools/networking/aws-xray-daemon/default.nix

+  src = fetchFromGitHub {
+    owner = "aws";
+    repo = "aws-xray-daemon";
+    rev = "${version}";


Suggested change

rev = "${version}";

rev = "V${version}";

worldofpeace · 2019-04-22T03:38:01Z

pkgs/tools/networking/aws-xray-daemon/default.nix

+{ stdenv, buildGoPackage, fetchFromGitHub }:
+
+buildGoPackage rec {
+  name = "aws-xray-daemon-${version}";


Suggested change

name = "aws-xray-daemon-${version}";

pname = "aws-xray-daemon";

name becomes ${pname}-${version} automatically.

worldofpeace · 2019-04-22T03:38:14Z

pkgs/tools/networking/aws-xray-daemon/default.nix

+
+  src = fetchFromGitHub {
+    owner = "aws";
+    repo = "aws-xray-daemon";


Suggested change

repo = "aws-xray-daemon";

repo = pname;

worldofpeace · 2019-04-22T03:39:17Z

nixos/modules/services/monitoring/aws-xray-daemon.nix

+      };
+    };
+  };
+}


missing final newline

worldofpeace · 2019-04-22T03:39:27Z

pkgs/tools/networking/aws-xray-daemon/default.nix

+    description = "aws X-RAY daemon.";
+    license = stdenv.lib.licenses.asl20;
+  };
+}


missing final newline

worldofpeace

Please bump aws-xray-daemon to its latest release

aws/aws-xray-daemon@7b7d269

infinisil · 2020-01-16T15:54:46Z

No activity in a while, closing for now. Feel free to reopen again

aws xray daemon nix package & nixos service.

2df62c7

NRHelmi requested a review from infinisil as a code owner January 7, 2019 14:27

AmineChikhaoui reviewed Jan 7, 2019

View reviewed changes

nixos/modules/services/monitoring/aws-xray-daemon.nix Outdated Show resolved Hide resolved

NRHelmi added 2 commits January 7, 2019 17:27

resolving comments.

44da7a1

Removing extra indents from deps.nix

d74ea5e

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 7, 2019

infinisil requested changes Feb 3, 2019

View reviewed changes

NRHelmi added 2 commits February 6, 2019 15:11

Revert "Removing extra indents from deps.nix"

ff54008

This reverts commit d74ea5e.

Xray: Resolving Infinisil comments.

466b8ec

NixOS deleted a comment from nixos-discourse Apr 11, 2019

ryantm requested changes Apr 11, 2019

View reviewed changes

worldofpeace reviewed Apr 22, 2019

View reviewed changes

nixos/modules/services/monitoring/aws-xray-daemon.nix

};

};

};

}

Copy link

Contributor

worldofpeace Apr 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing final newline

worldofpeace reviewed Apr 22, 2019

View reviewed changes

worldofpeace suggested changes Apr 22, 2019

View reviewed changes

infinisil closed this Jan 16, 2020

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 #53565

aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 #53565

NRHelmi commented Jan 7, 2019 •

edited

AmineChikhaoui commented Jan 7, 2019

AmineChikhaoui commented Jan 7, 2019

AmineChikhaoui commented Jan 10, 2019

nixos-discourse commented Jan 31, 2019

nixos-discourse commented Apr 11, 2019

ryantm Apr 11, 2019

ryantm Apr 11, 2019

ryantm Apr 11, 2019

worldofpeace Apr 22, 2019

worldofpeace Apr 22, 2019

worldofpeace Apr 22, 2019

worldofpeace Apr 22, 2019

worldofpeace left a comment

infinisil commented Jan 16, 2020

	enable = mkEnableOption "Whether to enable aws-xray-daemon service";
	enable = mkEnableOption "the aws-xray-daemon service";

	name = "aws-xray-daemon-${version}";
	pname = "aws-xray-daemon";

aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 #53565

aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 #53565

Conversation

NRHelmi commented Jan 7, 2019 • edited

Motivation for this change

Things done

I think I'm missing the maintainer. Don't know who to set to ?

AmineChikhaoui commented Jan 7, 2019

AmineChikhaoui commented Jan 7, 2019

AmineChikhaoui commented Jan 10, 2019

nixos-discourse commented Jan 31, 2019

nixos-discourse commented Apr 11, 2019

ryantm Apr 11, 2019

Choose a reason for hiding this comment

ryantm Apr 11, 2019

Choose a reason for hiding this comment

ryantm Apr 11, 2019

Choose a reason for hiding this comment

worldofpeace Apr 22, 2019

Choose a reason for hiding this comment

worldofpeace Apr 22, 2019

Choose a reason for hiding this comment

worldofpeace Apr 22, 2019

Choose a reason for hiding this comment

worldofpeace Apr 22, 2019

Choose a reason for hiding this comment

worldofpeace left a comment

Choose a reason for hiding this comment

infinisil commented Jan 16, 2020

NRHelmi commented Jan 7, 2019 •

edited