Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: 1.23.2 -> 1.24.1 #53642

Merged
merged 1 commit into from Jan 9, 2019
Merged

libuv: 1.23.2 -> 1.24.1 #53642

merged 1 commit into from Jan 9, 2019

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Jan 8, 2019 •
edited

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This basically reverts the changes from 1dca19f since the patch doesn’t apply anymore. As @matthewbauer suggested here to use the frameworks again.

andir
andir approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fairly clear. The upstream changelog reads non-intrusive. I do not expect much breakage from that. Given the impact size of this we will probably only know how bad things will be once we run it through hydra...

@andir andir merged commit 2e9235d into NixOS:staging Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lo1tuma @andir @GrahamcOfBorg