New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnuradio-osmosdr: 0.1.4 -> 4d83c60, Added support for Soapysdr #53646
Conversation
@betaboon Does gqrx work for you with the soapy drivers? I did try several times over last year and could never get it to work. |
@GrahamcOfBorg build gnuradio-with-packages gqrx |
@bjornfor @the-kenny |
@markuskowa: My personal opinion is that nixpkgs should only package released / stable upstream software. My thinking is that if a project, like osmosdr, has not produced a release in a long time, and the thinking is that users would benefit from getting the latest code, we should strive for making a release instead of working around it in nixpkgs. Think of other downstreams, if upstreams never release, all downstreams would eventually have to consider moving to unstable/unreleased code. And I think very few projects have a development process where all commits to git master branch are stable enough to be safely distributed to a wider user base.
Then I would say that's a good argument for upstream to make a release :-) |
@bjornfor I wrote an email to one of the developers a year ago, asking about a release, but did not get response. There is certainly a good argument to make a release, specially since the development branch seems to be pretty stable (works fine for me locally). |
going through the mailing-list archive i found:
I just hopped into irc://freenode#osmocom just asking around |
If I understand the mailing list right then there is no response for the request to make a new release? @betaboon did you get any response from the IRC? |
Wow.
I don't know what middle ground would be. I see these options:
Since I'm not an active maintainer (just a guy that played with SDR some time ago) I'm not going to say hard no to option 3. (But you know I prefer option 0.) |
@markuskowa i got told who in their IRC is the maintainer of gr-osmosdr (someone called here is the relevant excerpt of the chat:
|
Let's see if we get a response from the maintainers in the near future. |
Could you also add libbladeRF dependency so that there would be no need for a separate PR? |
@markuskowa it seems that other distros just use an unstable version. |
@greydot Yes, Debian uses ~90 patches but still calls it v0.1.4. It is essentially an unstable version. |
@markuskowa yes. v1.1.4 doesn't build with the latest libbladerf. The unstable code works just fine. See my closed PR linked above. |
I'd say unstable should be preferred in that case. Releases are worthless if not happening regularly. |
OK, it looks like the consensus is to go for the unstable version. We still have some to time to work out potential problems until 19.03. |
I talked to someone called For the time being I would be in favour of using a pinned commit in @greydot @markuskowa regarding the libbladeRF support. i have no way of testing that it works as i dont own a bladerf. If that is not sufficient for you (or you prefer |
@markuskowa I did test it successfully in the other PR with gqrx and osmocom_fft. |
When can we expect this (plus bladerf support) merged? |
}; | ||
|
||
nativeBuildInputs = [ pkgconfig ]; | ||
buildInputs = [ | ||
cmake boost gnuradio rtl-sdr uhd makeWrapper hackrf airspy | ||
cmake makeWrapper boost | ||
airspy gnuradio hackrf rtl-sdr soapysdr-with-plugins uhd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
soapysdr-with-plugins
needs to be conditional for linux otherwise gnuradio won't build on darwin anymore.
}: | ||
|
||
assert pythonSupport -> python != null && swig != null; | ||
|
||
stdenv.mkDerivation rec { | ||
name = "gnuradio-osmosdr-${version}"; | ||
version = "0.1.4"; | ||
version = "2018_08_15"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change that to dashes?
version = "2018_08_15"; | |
version = "2018-08-15"; |
@greydot I will merge it as soon as the changes mentioned above are made. |
744c9e5
to
63b0e31
Compare
@markuskowa i just adapted your requested changes I can say that it still compiles and works with my limesdr-mini (tested in gnuradio-companion and gqrx) |
@GrahamcOfBorg build gnuradio-with-packages |
I've just built and tested gqrx with bladeRF from this branch. Seems to work just fine. |
Thanks for all the effort! |
you're welcome. thanks for the nice and quick interaction to get this done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 53646 run on x86_64-linux 1
hmm, awkward, mistyped my review script. Sorry |
Motivation for this change
I needed support for limeSDR in gnuradio and gqrx,
This can be accomplished by using limesuite via soapysdr and soapysdr via gr-osmosdr.
So this results in a rebuild of:
gnuradio-companion
gqrx
qradiolink
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)