Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw: use current package set for headers #53605

Merged
merged 1 commit into from Jan 14, 2019

Conversation

matthewbauer
Copy link
Member

gccCrossStageStatic should not need targetPackages.

Fixes #53587.

gccCrossStageStatic should not need targetPackages.

Fixes NixOS#53587.
@Ericson2314
Copy link
Member

Ericson2314 commented Jan 14, 2019

Sorry I didn't comment on this earlier. I accept it's practically harmless and fixes the issue, but I would prefer if we did use targetPackages there. After trying it both ways with linuxHeaders I think it's better these header-only derivations come from the phase they would be if they were actual libraries. Since this use is for the toolchain which uses them in its runtime libraries, that would be targetPackages.

There should be some other way to fix this? I didn't yet investigate the error itself (why I hadn't commented).

@matthewbauer matthewbauer deleted the fix-53587 branch February 22, 2019 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants