Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.zfec: patch out argparse dependency #53616

Merged
merged 1 commit into from Jan 8, 2019

Conversation

MostAwesomeDude
Copy link
Contributor

Since argparse stopped doing anything a while ago, we'll just patch it out of setup.py and nobody will notice.

Motivation for this change

Fixes Tahoe-LAFS client tahoelafs. This is likely the only user of zfec.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

propagatedBuildInputs = [ pyutil ];

# argparse is in the stdlib but zfec doesn't know that.
patchPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postPatch

Since `argparse` stopped doing anything a while ago, we'll just patch it
out of setup.py and nobody will notice.
@FRidh FRidh merged commit 2c9de98 into NixOS:master Jan 8, 2019
@MostAwesomeDude MostAwesomeDude deleted the python-zfec-patch branch January 8, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants