pyznap: init at 1.1.2 #53563
pyznap: init at 1.1.2 #53563
Conversation
|
Is there anything more I need to do to move this forward? This is my first PR to nixpkgs so I'm still learning the process. |
pkgs/tools/backup/pyznap/default.nix
Outdated
| @@ -0,0 +1,28 @@ | |||
| { lib | |||
| , buildPythonApplication | |||
| , pythonOlder | |||
There was a problem hiding this comment.
pythonOlder is not used anywhere and probably should be removed from inputs.
|
|
||
| propagatedBuildInputs = [ configparser paramiko ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Does it have no checks or are they disable for a different reason? Please add a comment to make that clear.
There was a problem hiding this comment.
In that case just add the extra packages needed for testing to checkInputs.
There was a problem hiding this comment.
Further digging reveals that the PyPI release of the package doesn't include the tests.
|
And you will also have to add yourself to the list of maintainers in |
|
@FlorianFranzen thank you! |
rbrewer123
force-pushed
the
feature/pyznap-init
branch
from
7d67d1b
to
25ebdc1
Compare
|
I squashed commits for good measure. |
|
@FlorianFranzen is there anything else I need to do on this? |
|
It looks good to me, but I do not have commit rights. However, now that all checks are passing, you have a good chance that a maintainer might actually take a look at this and merge it. You might also be interested add a custom NixOS module to ease configuration of pyznap, similar to e.g. services.rsnapshot.*. |
|
@GrahamcOfBorg build pyznap |
|
@rbrewer123 thanks! |
Motivation for this change
Add pyznap ZFS snapshot package.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)