Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purescript: fix build compiling with ghc 8.4.4 #56162

Merged
merged 1 commit into from Mar 7, 2019
Merged

purescript: fix build compiling with ghc 8.4.4 #56162

merged 1 commit into from Mar 7, 2019

Conversation

jacereda
Copy link
Contributor

Closes #53597.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jacereda jacereda mentioned this pull request Feb 21, 2019
Merged
10 tasks
@peti
Copy link
Member

peti commented Feb 23, 2019

@GrahamcOfBorg build haskell.compiler.ghc822 haskell.compiler.ghc844

peti
peti requested changes Feb 23, 2019
View reviewed changes
pkgs/top-level/haskell-packages.nix Outdated Show resolved Hide resolved
@bbarker
Copy link
Contributor

bbarker commented Mar 6, 2019

would it be possible to get this merged, @jacereda ? Thanks for the work!

@jacereda
Copy link
Contributor Author

jacereda commented Mar 6, 2019

There was a conflict, I've rebased the changes.

@peti peti merged commit 33ebe0c into NixOS:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@FRidh FRidh Awaiting requested review from FRidh

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacereda @peti @bbarker @GrahamcOfBorg