Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashlog truncated with many news messages #7255

Closed
nielsmh opened this issue Feb 20, 2019 · 2 comments
Closed

Crashlog truncated with many news messages #7255

nielsmh opened this issue Feb 20, 2019 · 2 comments

Comments

@nielsmh
Copy link
Contributor

nielsmh commented Feb 20, 2019

Version of OpenTTD

After merge of #6709

Expected result

Crashlog written in full including the footer *** End of OpenTTD Crash Report ***.

Actual result

File is truncated after a fixed buffer length is exhausted.

Steps to reproduce

Load a savegame which produces a large number of news messages, for example gr0_50k_stations63 used for testing #7235. This game will produce a very large number of station acceptance news messages on the first day of loading. If a crash occurs before these news messages expire from "recent", the crash log is truncated.
@James103
Copy link
Contributor

Possible Fix: Depending on the amount of memory left for OpenTTD to allocate and the number of news messages, dynamically calculate and allocate the buffer to writing the OpenTTD crash report, instead of just assuming you will have no more than some number of recent news messages at the time of the crash and allocating a fixed buffer length for the crash report.

@stale
Copy link

stale bot commented Apr 23, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Apr 23, 2019
@LordAro LordAro added pinned and removed stale Stale issues labels Apr 25, 2019
LordAro added a commit to LordAro/OpenTTD that referenced this issue Apr 25, 2019
@LordAro
Fix OpenTTD#7255: Prevent crashlog corruption by only printing the 20…
04dad0c 
… most recent news messages
LordAro added a commit to LordAro/OpenTTD that referenced this issue Apr 27, 2019
@LordAro
Fix OpenTTD#7255: Prevent crashlog corruption by only printing the 32…
39351cc 
… most recent news messages
@PeterN PeterN closed this as completed in 47d0d86 Apr 29, 2019
michicc pushed a commit to michicc/OpenTTD that referenced this issue Jun 30, 2019
@LordAro @michicc
Fix OpenTTD#7255: Prevent crashlog corruption by only printing the 32…
e8168cc 
… most recent news messages. (OpenTTD#7542)
michicc pushed a commit that referenced this issue Jul 7, 2019
@LordAro @michicc
Fix #7255: Prevent crashlog corruption by only printing the 32 most r…
e6877d0 
…ecent news messages. (#7542)
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@LordAro @douiwby
Fix OpenTTD#7255: Prevent crashlog corruption by only printing the 32…
ddbbc4d 
… most recent news messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nielsmh @LordAro @James103