Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddgr: 1.1 -> 1.6 #56100

Merged
merged 2 commits into from Feb 21, 2019
Merged

ddgr: 1.1 -> 1.6 #56100

merged 2 commits into from Feb 21, 2019

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Feb 20, 2019

Motivation for this change

ddgr (DuckDuckGo CLI) 1.6 no longer requires the requests Python
package and includes the commit that patched zsh-completion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda requested changes Feb 20, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to maintainer-list.nix in a separate commit.

pkgs/applications/misc/ddgr/default.nix Outdated
@@ -1,29 +1,17 @@
{stdenv, fetchpatch, fetchFromGitHub, python3Packages}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{stdenv, fetchpatch, fetchFromGitHub, python3Packages}:
{stdenv, fetchpatch, fetchFromGitHub, python3}:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about making this change, but I thought that keeping the argument passed in as python3Packages might help avoid breakage of anyone manually passing arguments into this derivation. It's also possible that I'm mistaken. Happy to make the change if that's desired.

pkgs/applications/misc/ddgr/default.nix Outdated
url = "https://github.com/jarun/ddgr/commit/10c1a911a3d5cbf3e96357c932b0211d3165c4b8.patch";
})
];
buildInputs = [ python3Packages.python ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [ python3Packages.python ];
buildInputs = [ python3 ];

@ceedubs
Copy link
Contributor Author

ceedubs commented Feb 20, 2019

Thanks for the review, @dotlambda! Changes incoming shortly.

@ceedubs
ddgr: 1.1 -> 1.6
0094157 
ddgr (DuckDuckGo CLI) 1.6 no longer requires the `requests` Python
package and includes the commit that patched zsh-completion.
@ceedubs
Copy link
Contributor Author

ceedubs commented Feb 20, 2019

Review suggestions addressed.

@dotlambda
Copy link
Member

@GrahamcOfBorg build ddgr

@dotlambda dotlambda merged commit 2ca0cfb into NixOS:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ceedubs @dotlambda @GrahamcOfBorg