ddgr: 1.1 -> 1.6 #56100
Merged
ddgr: 1.1 -> 1.6 #56100
+10
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
11.by: package-maintainer
dotlambda
requested changes
Feb 20, 2019
| @@ -1,29 +1,17 @@ | |||
| {stdenv, fetchpatch, fetchFromGitHub, python3Packages}: | |||
There was a problem hiding this comment.
Suggested change
| {stdenv, fetchpatch, fetchFromGitHub, python3Packages}: | |
| {stdenv, fetchpatch, fetchFromGitHub, python3}: |
There was a problem hiding this comment.
I thought about making this change, but I thought that keeping the argument passed in as python3Packages might help avoid breakage of anyone manually passing arguments into this derivation. It's also possible that I'm mistaken. Happy to make the change if that's desired.
| url = "https://github.com/jarun/ddgr/commit/10c1a911a3d5cbf3e96357c932b0211d3165c4b8.patch"; | ||
| }) | ||
| ]; | ||
| buildInputs = [ python3Packages.python ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ python3Packages.python ]; | |
| buildInputs = [ python3 ]; |
|
Thanks for the review, @dotlambda! Changes incoming shortly. |
ddgr (DuckDuckGo CLI) 1.6 no longer requires the `requests` Python package and includes the commit that patched zsh-completion.
|
Review suggestions addressed. |
|
@GrahamcOfBorg build ddgr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ddgr (DuckDuckGo CLI) 1.6 no longer requires the
requestsPythonpackage and includes the commit that patched zsh-completion.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)