Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcptrace: init at 6.6.7 #56160

Closed
wants to merge 1 commit into from
Closed

tcptrace: init at 6.6.7 #56160

wants to merge 1 commit into from

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Feb 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Twey Twey force-pushed the tcptrace-6.6.7 branch 4 times, most recently from b4b6f3e to 990c1cd Compare February 22, 2019 14:09
@Twey Twey force-pushed the tcptrace-6.6.7 branch 2 times, most recently from c1a64d8 to cdb541e Compare February 23, 2019 13:21
Lassulus
Lassulus reviewed May 18, 2019
View reviewed changes
pkgs/tools/networking/tcptrace/default.nix
@@ -0,0 +1,49 @@
{ stdenv, fetchurl, libpcap }:
let
Copy link
Member

@Lassulus Lassulus May 18, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, some nitpicks though:
I really dislike this indentation, which results in a lot of diff noise if an attribute gets changed.
also Why is most of this inside a let and not inside the mkDerivation itself? having it inside a let makes it harder to override with overrideAttrs imho

@aanderse
Copy link
Member

@Twey are you able to continue with this PR and address the issues mentioned?

@aanderse
Copy link
Member

Please feel free to reopen this request if you are interested in continuing.

@aanderse aanderse closed this Aug 25, 2019
@gmacon gmacon mentioned this pull request Feb 1, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@Lassulus Lassulus Lassulus left review comments

@symphorien symphorien symphorien left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Twey @aanderse @Mic92 @Lassulus @symphorien @GrahamcOfBorg