Skip to content

file: 5.35 -> 5.36 #56126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

file: 5.35 -> 5.36 #56126

merged 1 commit into from
Feb 21, 2019
+2 −2

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 21, 2019

https://mailman.astron.com/pipermail/file/2019-February/000073.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@etu
Copy link
Contributor

etu commented Feb 21, 2019

Staging instead of master maybe? :-)

@dtzWill dtzWill changed the base branch from master to staging February 21, 2019 18:49
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 21, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Feb 21, 2019 via email

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 5001+ and removed 10.rebuild-darwin: 501-1000 6.topic: GNOME GNOME desktop environment and its underlying platform labels Feb 21, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501-1000 and removed 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 5001+ labels Feb 21, 2019
@dtzWill dtzWill merged commit b7eadcf into NixOS:staging Feb 21, 2019
@dtzWill dtzWill deleted the update/file-5.36 branch February 21, 2019 22:54
@dtzWill dtzWill mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk

@FRidh FRidh

@infinisil infinisil

@matthewbauer matthewbauer

@peti peti

@ryantm ryantm

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @etu @GrahamcOfBorg