emacsPackagesNg.lua-mode: Fix hash #56123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had cleaned that cache up, but fortunately I had another computer with nix that I haven't touched in a while that has this in the nix store. Here is the file: [redacted] How can I verify that this has the same hash? Although it should. Thanks for looking into this. |
|
Thanks! A fixed output derivation only has the same hash when the output path is the same. |
infinisil
added a commit
to infinisil/lua-mode
that referenced
this pull request
Apr 4, 2020
This prevents GitHub's tarballs from changing depending on whether a branch points to the commit or not. E.g. on latest master, %d would evaluate to "master", whereas once master is updated again, the same commit wouldn't be master anymore, meaning %d evaluates to "". This is the cause for PRs NixOS/nixpkgs#56123 and NixOS/nixpkgs#84277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54641
While this file is indeed autogenerated (which usually means you shouldn't change it), it's okay in this case, because this change is supposed to only be temporary anyways, so it automatically gets "undone" when the next automatic update is done.
Ping @terlar @endgame @vlaci
I'm probably a bit late with this request, but if you still have them, can you upload the /nix/store paths of the older lua-mode version, @terlar? The
/nix/store/sc08qxggk9nwj730s20yz8q81d7gfjgy-sourceone with hash04m9njcpdmar3njjz4x2qq26xk0k6qprcfzx8whlmvapqf8w19iz. Preferably withnix-store --export /nix/store/sc08qxggk9nwj730s20yz8q81d7gfjgy-source > lua-sourceand then uploading the lua-source file. This would then be importable by other people withnix-store --import < lua-source.Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)