Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tahoe service #56175

Merged
merged 2 commits into from May 25, 2019
Merged

Tahoe service #56175

merged 2 commits into from May 25, 2019

Conversation

MostAwesomeDude
Copy link
Contributor

Motivation for this change

Fix #25273 and update the NixOS service for the Tahoe 1.13 CLI changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have not dogfooded these changes, in contrast to my usual Tahoe adventures. I would greatly appreciate independent confirmation that this works for folks.

@MostAwesomeDude
services.tahoe: Use networking.hostName.
fa6ad02 
Previously we used nothing, leading to NixOS#25273.

Big thanks to @t184256 for developing and testing this fix.

Fixes NixOS#25273.
@MostAwesomeDude
services.tahoe: Use 1.13-compatible invocations.
00d6b4c
infinisil
infinisil approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since some time has passed, I'll wait for your OK before merging.

rycee
rycee approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using these changes for a while now on 19.03 and they work well. As far as I can tell the module is useless without these changes so I would suggest a merge and a backport to 19.03.

@infinisil infinisil merged commit 0040ca9 into NixOS:master May 25, 2019
@infinisil
Copy link
Member

infinisil commented May 25, 2019 •
edited

Backported in 41c8f21 (and parent)

@rycee
Copy link
Member

rycee commented May 25, 2019

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee approved these changes

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tahoe-LAFS service module is broken
4 participants
@MostAwesomeDude @infinisil @rycee @GrahamcOfBorg