Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: add missing systemd restart options #56152

Merged
merged 1 commit into from Feb 21, 2019
Merged

nixos/kubernetes: add missing systemd restart options #56152

merged 1 commit into from Feb 21, 2019

Conversation

adamtulinius
Copy link
Member

Motivation for this change

Kube scheduler and kube proxy were missing the options to make systemd restart the processes on failure.

Tested locally using nix-build ./nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

johanot
johanot approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@johanot johanot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @fpletz @calbrecht

fpletz
fpletz approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On bootstrap both processes do fail but are somehow restarted nonetheless. As it's the behavior we want, we should definitely add this explicitly.

@fpletz fpletz merged commit 8ef1e41 into NixOS:master Feb 21, 2019
@adamtulinius adamtulinius deleted the k8s-scheduler-missing-restart branch February 21, 2019 15:18
@johanot
Copy link
Contributor

johanot commented Feb 21, 2019

@fpletz @adamtulinius for the record, this is why they're restarted: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/cluster/kubernetes/scheduler.nix#L88 ..

Certmgr will restart dependent services once their certificate(s) are issued/renewed. I guess we were "lucky", that the scheduler and proxy didn't fail after the certs were issued. In that case nothing would have restarted them. Same issue when easyCerts = false and certmgr is disabled. :-)

@fpletz
Copy link
Member

fpletz commented Feb 21, 2019

Thanks for the explanation! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@johanot johanot johanot approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamtulinius @johanot @fpletz @GrahamcOfBorg