Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7091: Close dropdown menu windows after rebuilding AI/GS settings #7092

Merged
merged 1 commit into from Feb 20, 2019
Merged

Fix #7091: Close dropdown menu windows after rebuilding AI/GS settings #7092

merged 1 commit into from Feb 20, 2019

Conversation

SamuXarick
Copy link
Contributor

No description provided.

@glx22
Copy link
Contributor

glx22 commented Jan 26, 2019

This PR fixes one specific problem but there are more things to fix to do it properly. The AI windows need a closer look to find and fix all missing invalidation/close.

michicc
michicc approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@michicc michicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not fix everything that is wrong, but a fix is still better than no fix at all, me thinks.

@michicc michicc merged commit 19fa960 into OpenTTD:master Feb 20, 2019
@SamuXarick SamuXarick deleted the ai-gs-hide-dropdown-menu branch April 11, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michicc michicc michicc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamuXarick @glx22 @michicc