Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shab: init at 1.0.0 #56164

Merged
merged 3 commits into from Feb 22, 2019
Merged

shab: init at 1.0.0 #56164

merged 3 commits into from Feb 22, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 21, 2019 •
edited

Motivation for this change

馃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm requested a review from roberth February 21, 2019 20:53
@zimbatm
Copy link
Member Author

zimbatm commented Feb 22, 2019

@markuskowa let me know if you see anything else

@markuskowa
Copy link
Member

@zimbatm looks good now. There's just some typos left.
Out of curiosity: the passthru exposes render and renderText. I guess you want to use shab as a build tool in other derivations?

markuskowa and others added 2 commits February 22, 2019 13:31
@markuskowa @zimbatm
Update pkgs/tools/text/shab/default.nix
b16b283 
Co-Authored-By: zimbatm <zimbatm@zimbatm.com>
@markuskowa @zimbatm
Update pkgs/tools/text/shab/default.nix
4afe7f0 
Co-Authored-By: zimbatm <zimbatm@zimbatm.com>
@zimbatm
Copy link
Member Author

zimbatm commented Feb 22, 2019

yeah, I think it might be a good replacement for pkgs.substituteAll in some cases.

@zimbatm zimbatm merged commit b6c8218 into NixOS:master Feb 22, 2019
@zimbatm zimbatm deleted the shab-1.0.0 branch February 22, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@roberth roberth Awaiting requested review from roberth

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @markuskowa @GrahamcOfBorg