Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipad_charge: enable installation udev rules #56131

Merged
merged 1 commit into from Jun 11, 2019
Merged

ipad_charge: enable installation udev rules #56131

merged 1 commit into from Jun 11, 2019

Conversation

mbrock
Copy link
Contributor

@mbrock mbrock commented Feb 21, 2019

Note that you need to add this package to your
services.udev.packages list rather than your
environment.systemPackages for the udev rules to take effect.

It might be worthwhile giving this its own configuration option, which
could be documented in man configuration.nix.

Motivation for this change

The current package ignores the udev rules, but they are very useful for getting your iPads to charge automatically when connected via USB.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mbrock
ipad_charge: enable installation udev rules
d4f65c3 
Note that you need to add this package to your
`services.udev.packages` list rather than your
`environment.systemPackages` for the udev rules to take effect.

It might be worthwhile giving this its own configuration option, which
could be documented in `man configuration.nix`.
@matthewbauer matthewbauer merged commit 82dd4e0 into NixOS:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbrock @matthewbauer @GrahamcOfBorg