Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tautulli/plexpy: 1.4.25 -> 2.1.26 (renamed) #56171

Merged
merged 2 commits into from Mar 8, 2019
Merged

tautulli/plexpy: 1.4.25 -> 2.1.26 (renamed) #56171

merged 2 commits into from Mar 8, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Feb 21, 2019

PlexPy was renamed to Tautulli.

This renames the module as well as the application accordingly.
Aliases are kept for backwards compatibility.

Motivation for this change

Update to latest version of Tautulli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
Copy link
Member Author

bachp commented Feb 25, 2019

/cc @csingley as you are the current maintainer

@csingley
Copy link
Contributor

Nice one, thanks. Looks good!

@csingley
Copy link
Contributor

@bachp
See ecbe7b0
Please incorporate those changes (using systemd.tmpfiles.rules instead of systemd.services.tautulli.preStart and systemd.services.tautulli.serviceConfig.PermissionsStartOnly), so we can get a solid package committed without any deprecated functionality.

Thanks again for bringing this up to date.

aanderse and others added 2 commits February 28, 2019 18:54
@aanderse @bachp
nixos/plexpy: replace deprecated usage of PermissionsStartOnly
51c897c 
see NixOS#53852
@bachp
tautulli/plexpy: 1.4.25 -> 2.1.26 (renamed)
8b3ffeb 
PlexPy was renamed to Tautulli.

This renames the module as well as the application accordingly.
Aliases are kept for backwards compatibility.

# Conflicts:
#	nixos/modules/services/misc/tautulli.nix
@bachp
Copy link
Member Author

bachp commented Feb 28, 2019

@csingley I rebased this on top of @aanderse s commit

@csingley
Copy link
Contributor

Looks like a winner!

@aanderse aanderse mentioned this pull request Mar 2, 2019
Merged
10 tasks
@bachp
Copy link
Member Author

bachp commented Mar 6, 2019

@infinisil anything else that needs to be changed here?

@infinisil infinisil merged commit a540993 into NixOS:master Mar 8, 2019
@infinisil
Copy link
Member

Looking good thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bachp @csingley @infinisil @GrahamcOfBorg @aanderse