Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lepton: init at 1.2.1 #56108

Merged
merged 2 commits into from Feb 21, 2019
Merged

lepton: init at 1.2.1 #56108

merged 2 commits into from Feb 21, 2019

Conversation

artemist
Copy link
Member

Motivation for this change

Lepton is Dropbox's JPEG compression program. It was not previously packaged.

Things done

Add a lepton package for Linux. Note that it requires some Linux-specific things (glibc.static) and I do not have a Mac to test the required modifications

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Feb 20, 2019

@GrahamcOfBorg build lepton

@Ma27
Copy link
Member

Ma27 commented Feb 20, 2019

Built and tested locally 👍

According to the ofBorg CI, it doesn't build on aarch64-linux as well. I'm currently trying to get the cross build running on my machine to see if we can do something about it.

Regarding the darwin issues: I'd leave it disabled for now until somebody with the needed resources can help out :)

@artemist
Copy link
Member Author

Even if we switch to using system dependencies (it wants a specific version of zlib and has it in-tree), I don't think it will work because it uses Intel SIMD intrinsics. There is SSE2NEON, but that may be outside of the scope of this package

@Ma27
lepton: only build on x86_64-linux for now
a55d96b 
Darwin and `aarch64-linux` builds currently fail[1][2].

Also cleaned up the `meta` section a bit.

[1] https://github.com/NixOS/nixpkgs/pull/56108/checks?check_run_id=66442317
[2] NixOS#56108 (comment)
@Ma27
Copy link
Member

Ma27 commented Feb 21, 2019

I tried a cross build with nix-build -E "with import ./. { crossSystem.config = \"aarch64-linux\"; }; lepton", but I didn't even get the glibc to compile. I now pushed a fix which disables all builds except x86_64-linux for now, if builds on other platforms are needed and possible, we can still fix this afterwards.

If you're fine with my patch, I'd wait for ofBorg to complete and mergen then :)

@artemist
Copy link
Member Author

That looks good! I'm pretty new to Nix, so my code isn't the best

@Ma27 Ma27 merged commit de2bb10 into NixOS:master Feb 21, 2019
@Ma27
Copy link
Member

Ma27 commented Feb 21, 2019

@artemist thanks!

@artemist artemist deleted the lepton branch March 7, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artemist @Ma27 @GrahamcOfBorg