Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs-w3m: Update 2013-03-21 -> 2019-02-20 #56133

Closed
wants to merge 1 commit into from
Closed

emacs-w3m: Update 2013-03-21 -> 2019-02-20 #56133

wants to merge 1 commit into from

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Feb 21, 2019

Motivation for this change

Package wildly out of date. I updated this and then realized that I could have just used the (m)elpa version. Should we update or remove this?

Things done

(require 'w3m-load), M-x w3m, go to google.com and submit a test search query.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Feb 21, 2019
View reviewed changes
pkgs/applications/editors/emacs-modes/emacs-w3m/default.nix
url = "http://github.com/emacs-w3m/emacs-w3m";
rev = "7fa00f90b3bff8562768d0a15b32012cededcb47";
sha256 = "15q40aqfda40slkgs0fg0svm0x47a98nz81ysxb5nh0kr45ha67i";
leaveDotGit = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can easily break the checksum if git is updated.
Depending on how it uses git. The git binary can be also stubbed out:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/misc/flameshot/default.nix#L26

The melpa version would be also fine. Does it have w3m available automatically?

@adisbladis
Copy link
Member

adisbladis commented Aug 6, 2019 •
edited

I'd like us to completely drop this package and rely on melpa packages where possible.

@clefru Could you instead apply an override to the melpa generated package? That would make w3m easy to update with the rest of the melpa.

edit: It turns out we already have such an override, if that's working we should drop this package.

@clefru
Copy link
Contributor Author

clefru commented Aug 7, 2019

@adisbladis : I can confirm that the melpa generated w3m package from master works well. Thanks, that's a much better approach! Closing PR.

@clefru clefru closed this Aug 7, 2019
@clefru clefru deleted the emacs-w3m branch August 7, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: emacs 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@clefru @adisbladis @Mic92 @infinisil @GrahamcOfBorg