Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wmfs: init at 201902 #56132

Merged
merged 1 commit into from
Mar 22, 2019
Merged

wmfs: init at 201902 #56132

merged 1 commit into from
Mar 22, 2019
+44 −0

Conversation

balsoft
Copy link
Member

@balsoft balsoft commented Feb 21, 2019 •
edited
Loading

Motivation for this change

This adds wmfs, Window Manager From Scratch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 21, 2019
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 23, 2019
@joachifm
Copy link
Contributor

@GrahamcOfBorg build wmfs

@balsoft
Copy link
Member Author

balsoft commented Mar 10, 2019

Whoops. I though it could build on darwin. It does build on linux for sure, though.

@balsoft
Copy link
Member Author

balsoft commented Mar 10, 2019

@joachifm , can you toggle the build again?

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 10, 2019
@joachifm
Copy link
Contributor

@GrahamcOfBorg build wmfs

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2019
@joachifm
Copy link
Contributor

Is this ready to go?

@balsoft
Copy link
Member Author

balsoft commented Mar 18, 2019

I'm not sure at this point, I have messed up too many times with meta. I hope it builds, but no promises.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build wmfs

@balsoft
Copy link
Member Author

balsoft commented Mar 22, 2019

Yay!
Now it's time to clean up the code and squash the commits into one.

@joachifm joachifm merged commit 91943f7 into NixOS:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balsoft @joachifm @symphorien @GrahamcOfBorg