python3Packages.imageio: 2.4.1 -> 2.5.0 #56135
Conversation
pmiddend
force-pushed
the
imageio-update
branch
from
2a738f7
to
0ef547a
Compare
pmiddend
force-pushed
the
imageio-update
branch
from
0ef547a
to
96c2be4
Compare
|
@dotlambda I corrected all the things you noticed (thanks for the thorough review btw!), but noticed that imageio has an incompatibility with Python 2.7 anymore, see imageio/imageio#436 - so we'll have to wait for a word from the author. |
| checkInputs = [ pytest psutil ]; | ||
| checkInputs = [ pytest psutil ] ++ stdenv.lib.optionals isPy3k [ | ||
| imageio-ffmpeg ffmpeg | ||
| ]; | ||
| propagatedBuildInputs = [ numpy pillow ] ++ stdenv.lib.optionals (!isPy3k) [ | ||
| futures | ||
| enum34 |
There was a problem hiding this comment.
I suspect this is where you could add pathlib (for imageio/imageio#436)
There was a problem hiding this comment.
@almarklein Thanks, that's exactly where I put them.
| , pytest | ||
| , numpy | ||
| , isPy3k | ||
| , ffmpeg |
There was a problem hiding this comment.
Are you sure that ffmpeg (and imageio-ffmpeg) should be hard-dependencies here? They are optional dependencies from imageio's point of view, mainly because ffmpeg is quite heavy.
There was a problem hiding this comment.
@almarklein I see your concern, but declaring it as a function parameter in the place you mention isn't really "depending" on it at runtime. It's just used as part of checkInputs, to execute the tests.
pmiddend
force-pushed
the
imageio-update
branch
from
96c2be4
to
7f53673
Compare
|
@GrahamcOfBorg build python2.pkgs.imageio python3.pkgs.imageio |
pmiddend
force-pushed
the
imageio-update
branch
from
7f53673
to
47519a1
Compare
|
@dotlambda Fixed. |
|
@GrahamcOfBorg build python2.pkgs.imageio python3.pkgs.imageio |
Motivation for this change
imageio now optionally needs imageio-ffmpeg, which I also put into this PR.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)