Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profanity: Fix build #56118

Merged
merged 1 commit into from Feb 22, 2019
Merged

profanity: Fix build #56118

merged 1 commit into from Feb 22, 2019

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Feb 21, 2019

Motivation for this change

Profanity hasn't been able to build since 1. This patch addresses the
issue by introducing autoconf-archive and removing NIX_CFLAGS_COMPILE
as well as LDFLAGS as a consequence since autoconf-archive is able to
handle the AX_PYTHON extension used by Profanity's upstream autoconf
file.

Thanks to @aszlig for helping with this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@devhell
applications/profanity: Fix build
c557312 
Profanity hasn't been able to build since [1]. This patch addresses the
issue by introducing `autoconf-archive` and removing NIX_CFLAGS_COMPILE
as well as LDFLAGS as a consequence since `autoconf-archive` is able to
handle the AX_PYTHON extension used by Profanity's upstream autoconf
file.

Thanks to @aszlig for helping with this.

[1]: NixOS@efbe87f
@devhell devhell changed the title applications/profanity: Fix build profanity: Fix build Feb 21, 2019
@erictapen
Copy link
Member

Great! This fixes #53993.

@dywedir
Copy link
Member

dywedir commented Feb 22, 2019

@GrahamcOfBorg build profanity

@dywedir
Copy link
Member

dywedir commented Feb 22, 2019

Thanks!

@dywedir dywedir merged commit 9aa592e into NixOS:master Feb 22, 2019
@devhell devhell deleted the fix_profanity branch February 26, 2019 18:41
@devhell devhell mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devhell @erictapen @dywedir @GrahamcOfBorg