Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beanstalkc: 0.4.0 -> 0.5.2 #56117

Merged
merged 1 commit into from Feb 22, 2019
Merged

beanstalkc: 0.4.0 -> 0.5.2 #56117

merged 1 commit into from Feb 22, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 21, 2019

Motivation for this change

Version bump which adds python3 support, requested by @flokli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from FRidh as a code owner February 21, 2019 02:07
};

doCheck = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run with tests using this: checkInputs = [ fixtures testfixtures ]; but then got errors. I'm not much of a python guy... Any ideas?

running install tests
running test
running egg_info
writing beanstalkc.egg-info/PKG-INFO
writing dependency_links to beanstalkc.egg-info/dependency_links.txt
writing top-level names to beanstalkc.egg-info/top_level.txt
reading manifest file 'beanstalkc.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '' under directory 'tests'
warning: no previously-included files matching 'pycache' found under directory '
'
warning: no previously-included files matching '.py[co]' found under directory ''
warning: no files found matching '*.rst' under directory 'docs'
warning: no files found matching 'conf.py' under directory 'docs'
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'make.bat' under directory 'docs'
writing manifest file 'beanstalkc.egg-info/SOURCES.txt'
running build_ext
no-yaml_fixtures (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: no-yaml_fixtures (unittest.loader._FailedTest)

ImportError: Failed to import test module: no-yaml_fixtures
Traceback (most recent call last):
File "/nix/store/yv4pzx3lxk3lscq0pw3hqzs7k4x76xsm-python3-3.7.2/lib/python3.7/unittest/loader.py", line 154, in loadTestsFromName
module = import(module_name)
File "/build/source/test/no-yaml_fixtures.py", line 1, in
from fixtures import setup, teardown
ImportError: cannot import name 'setup' from 'fixtures' (/nix/store/ln0606pl00cp7mmx88pks1nj3908y6cx-python3.7-fixtures-3.0.0/lib/python3.7/site-packages/fixtures/init.py)


Ran 1 test in 0.000s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
builder for '/nix/store/i821602xydczrs8qlq4mgj590rch0s2v-python3.7-beanstalkc-0.5.2.drv' failed with exit code 1
error: build of '/nix/store/i821602xydczrs8qlq4mgj590rch0s2v-python3.7-beanstalkc-0.5.2.drv' failed

@aanderse
Copy link
Member Author

@GrahamcOfBorg build python27Packages.beanstalkc python3Packages.beanstalkc

@flokli flokli merged commit bd2b0d0 into NixOS:master Feb 22, 2019
@flokli
Copy link
Contributor

flokli commented Feb 22, 2019

@aanderse thanks! can you bump the nixos beanstalk test to use python3?

@aanderse aanderse deleted the beanstalkc branch February 22, 2019 18:44
@aanderse
Copy link
Member Author

@aanderse thanks! can you bump the nixos beanstalk test to use python3?

Will do!

Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants